So there are quite a few components to code optimisation and refactoring of code.
The largest indicator for me is cyclomatic complexity, I work on the bases of anything over 7 should be refactored.
I want other methods of detecting code issues with large projects that other people use, specifically with SharePoint.
Regards,
Hugh
Hi Hugh
Over the last few months I’ve been doing a lot of code reviews for a clients external partner solutions;
1. I use SPCAF/SPCOP to point towards areas of SP specific bad practice
2. Code Analysis (VS and Resharper) including complexity/LOC to point towards code that may be ‘bad’
3. Make a point of looking at common points of failure/bad coding such as webconfig mods, feature receivers, event receivers, I also look at feature manifests looking for scope mismatches
I decided pretty early on that I could never review solutions enough to warrant them fit for purpose, so now when I do these I’m looking for anything that might damage the clients farm; performance, stability, availability etc.
I guess your MO for conducting internal team reviews might well be different though
